| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Index maintenance function for BRIN doesn't check RecoveryInProgress() |
| Date: | 2018-06-14 02:12:07 |
| Message-ID: | 20180614021207.GF1597@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 14, 2018 at 02:06:57AM +0900, Masahiko Sawada wrote:
> On Thu, Jun 14, 2018 at 12:04 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> On 13 June 2018 at 15:51, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>> I guess you could go either way ... we're just changing one unhelpful
>>> error with a better one: there is no change in behavior. I would
>>> backpatch this, myself, and avoid the code divergence.
>>
>> WAL control functions all say the same thing, so we can do that here also.
>
> +1
+1 for a back-patch to v10. The new error message brings clarity in my
opinion.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2018-06-14 02:22:48 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |
| Previous Message | Michael Paquier | 2018-06-14 02:09:30 | Re: Partitioning with temp tables is broken |