| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix and document lock handling for in-memory replication slot da |
| Date: | 2018-06-11 21:47:27 |
| Message-ID: | 20180611214727.GA2269@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Jun 11, 2018 at 09:49:52AM -0700, Andres Freund wrote:
> Same is true for the codepaths calling GetRedoRecPtr().
You are right. I'll fix in a minute. A first commit's stress make
things really harder to get right...
> I don't object to the general idea of adding locking - although the
> benefit are nearly guaranteed to be cosmetic - but this has the
> potential to make things worse.
Thanks.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-06-11 21:53:50 | pgsql: Fix oversight from 9e149c8 with spin-lock handling |
| Previous Message | Tom Lane | 2018-06-11 21:36:03 | pgsql: Improve commentary about run-time partition pruning data structu |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-06-11 22:11:05 | Re: Fix some error handling for read() and errno |
| Previous Message | Robbie Harwood | 2018-06-11 21:42:32 | Re: Fix some error handling for read() and errno |