Re: SHOW ALL does not honor pg_read_all_settings membership

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
Date: 2018-06-11 01:38:14
Message-ID: 20180611013814.GF7066@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 08, 2018 at 03:13:57PM -0400, Alvaro Herrera wrote:
> And I think this fixes it.

- if (conf->source == PGC_S_FILE && superuser())
+ if (conf->source == PGC_S_FILE &&
+ is_member_of_role(GetUserId(), DEFAULT_ROLE_READ_ALL_SETTINGS))

Thanks Alvaro! This bit in GetConfigOptionByNum() looks fine to me.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-06-11 01:55:33 Re: why partition pruning doesn't work?
Previous Message Michael Paquier 2018-06-11 01:19:18 Re: Loaded footgun open_datasync on Windows