Re: pg_config.h.win32 missing a set of flags from pg_config.h.in added in v11 development

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, buildfarm(at)sraoss(dot)co(dot)jp, dpage(at)postgresql(dot)org, chris(at)chrullrich(dot)net
Subject: Re: pg_config.h.win32 missing a set of flags from pg_config.h.in added in v11 development
Date: 2018-06-03 08:29:41
Message-ID: 20180603082941.GA1820@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jun 02, 2018 at 05:20:57PM -0400, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> On 02/06/18 17:09, Tom Lane wrote:
>>> More concerning is that RHEL6 is on 1.0.1e:
>
>> I was only thinking of requiring 1.0.2 on Windows.
>
> Ah. Personally, I don't care about that case, but maybe somebody
> else wants to speak for it?

That's what I meant as well. Cutting the minimal OpenSSL version on
Linux would not come I think without complains so the requirements are
way higher. I know of companies compiling and running benchmarks of
PostgreSQL on past RHEL and SUSE versions, linking to what's locally
available for simplicity.

A script which reports the version of OpenSSL should be simple enough
for MSVC. And I am ready to bet that at least hamerkop is not using
OpenSSL 1.0.2, so a simple switch would most likely cause the buildfarm
to go red. I am attaching in CC the maintainers of the Windows animals
so as they can comment.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2018-06-03 16:44:33 Re: why partition pruning doesn't work?
Previous Message Michael Paquier 2018-06-03 08:04:21 Re: New committers announced at PGCon 2018