Re: plperl fails with perl 5.28

From: Christoph Berg <myon(at)debian(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plperl fails with perl 5.28
Date: 2018-05-29 18:49:49
Message-ID: 20180529184948.GA5510@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Tom Lane 2018-05-23 <10366(dot)1527109807(at)sss(dot)pgh(dot)pa(dot)us>
> > https://rt.perl.org/Public/Bug/Display.html?id=133220
>
> Thanks. Looking at this again, it seems like the core of the problem
> is that S_run_body's fell-off-the-end behavior is equivalent to an
> explicit "exit(0)". Perhaps it should not be. I can see the point of
> treating "exit(0)" as an unusual quasi-error case, but fell-off-the-end
> probably shouldn't be.
>
> However, then somebody would have to look around and see if there are
> any other uses of my_exit(0) that need to be rethought ...

The perl_run() part of the change was just reverted:
https://rt.perl.org/Ticket/Display.html?id=133220#txn-1556788

Christoph

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2018-05-29 19:08:49 Re: "column i.indnkeyatts does not exist" in pg_upgrade from 11dev to 11b1
Previous Message Andres Freund 2018-05-29 18:13:15 Re: found xmin from before relfrozenxid on pg_catalog.pg_authid