Re: Infinite loop on master shutdown

At Thu, 17 May 2018 09:20:01 -0700, Andres Freund <andres(at)anarazel(dot)de> wrote in <20180517162001(dot)rzd7l6g2h66hvzvd(at)alap3(dot)anarazel(dot)de>
> Hi,
>
> On 2018-05-17 17:19:00 +0900, Kyotaro HORIGUCHI wrote:
> > Hello, as in pgsql-bug ML.
> >
> > https://www.postgresql.org/message-id/20180517.170021.24356216.horiguchi.kyotaro@lab.ntt.co.jp
> >
> > Master can go into infinite loop on shutdown. But it is caused by
> > a broken database like storage rolled-back one. (The steps to
> > replay this is shown in the above mail.)
> >
> > I think this can be avoided by rejecting a standby if it reports
> > that write LSN is smaller than flush LSN after catching up.
> >
> > Is it worth fixing?
>
> I'm very doubtful. If you do bad stuff to a standby, bad things can
> happen...

Yes, I doubted its worthiness since I didn't find more natural
way to cause that.

Thanks for the opinion.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center