Re: Cache lookup errors with functions manipulation object addresses

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Cache lookup errors with functions manipulation object addresses
Date: 2018-05-14 20:27:48
Message-ID: 20180514202748.rerj7veodv2gpitk@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2018-Mar-06, Michael Paquier wrote:

> On Mon, Mar 05, 2018 at 12:57:38PM +0000, Aleksander Alekseev wrote:
> > It looks like that this patch doesn't apply anymore:
> >
> > The new status of this patch is: Waiting on Author
> Yes, this happens because patch 0003 from the last series has been
> committed as a26116c6. Attached is a rebased set, though the patches
> have no actual changes as those are able to apply correctly.

I forgot to mention this earlier: I think external FDWs do not really
benefit from your 0001 (neither do most of the internal callsites of the
modified functions). I checked a bunch of source files and nowhere I
got a "Gee, I wish this returned InvalidOid if the object in question
didn't exist" feeling.

I think we're better off adding a new function and avoid changing the
signature of GetForeignServer et al. Or maybe rename the function and
keep the original name as a compatibility wrapper macro.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-05-14 20:28:50 Re: Postgres 11 release notes
Previous Message Bruce Momjian 2018-05-14 20:10:58 Re: Postgres 11 release notes