Re: perlcritic and perltidy

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: perlcritic and perltidy
Date: 2018-05-07 00:23:50
Message-ID: 20180507002350.GC27389@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 06, 2018 at 01:46:28PM -0400, Stephen Frost wrote:
> I definitely prefer to have the braces on their own line- makes working
> with the files a lot easier when you've got a lot of hashes
> (particularly thinking about the hashes for the pg_dump regression
> tests..). Having them on independent lines would have saved me quite a
> few keystrokes when I reworked those tests.

Agreed with Stephen's argument. Let's keep the braces on the same
line. I have also been annoyed a couple of times with the format which
adds a new line just for a brace.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-05-07 01:14:06 Re: perlcritic and perltidy
Previous Message Michael Paquier 2018-05-07 00:18:11 Refreshing findoidjoins for v11