Extra newlines added even if PQerrorMessage

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Extra newlines added even if PQerrorMessage
Date: 2018-05-06 23:52:39
Message-ID: 20180506235239.GA13286@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

2f52518 has removed a couple of extra newlines not needed as
PQerrorMessage is used, but some places have been missed:
- testlo64.c
- testlo.c
- findoidjoins.c
Those are not really critical, still I think that it would be good
practice to be consistent.

pgbench uses at one place CommandFailed() which appends automatically a
newline for the message passed by the caller, and calls one
PQerrorMessage. Perhaps CommandFailed()'s callers should just define a
newline in the message? Or it could be better to have a version of
pchomp for frontends?


Attachment Content-Type Size
pqerror-newlines.patch text/x-diff 4.2 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-05-07 00:18:11 Refreshing findoidjoins for v11
Previous Message Charles Cui 2018-05-06 21:16:01 Re: GSoC 2018: thrift encoding format