| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | perlcritic (was Re: pgsql: Fix precedence problem in new Perl code.) |
| Date: | 2018-05-04 21:36:05 |
| Message-ID: | 20180504213605.zsgi7qdontixhveq@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Moving discussion to -hackers list.
Mike Blackwell wrote:
> I didn't see a .perlcriticrc file in the project, so ran with our local
> settings.
>
> With those, perlcritic is pretty unhappy, even at -4, though I don't see
> anything that pops out as potentially bug-inducing.
Uh, we've certainly fixed things to appease perlcritic before (see git
log --grep perlcritic). Maybe we need to come up with some .rc file to
our liking and try to adhere to it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mike Blackwell | 2018-05-04 22:26:24 | Re: perlcritic (was Re: pgsql: Fix precedence problem in new Perl code.) |
| Previous Message | Mike Blackwell | 2018-05-04 21:28:10 | Re: pgsql: Fix precedence problem in new Perl code. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2018-05-04 21:54:55 | Re: Built-in connection pooling |
| Previous Message | Mike Blackwell | 2018-05-04 21:28:10 | Re: pgsql: Fix precedence problem in new Perl code. |