Re: Verbosity of genbki.pl

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, John Naylor <jcnaylor(at)gmail(dot)com>
Subject: Re: Verbosity of genbki.pl
Date: 2018-04-28 17:02:10
Message-ID: 20180428170210.GT27724@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > Maybe we can take another look at this. Right now, make -s world
> > produces *only* the following output:
>
> > $ make -s world
> > Generating BKI files and symbol definition headers...
> > Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...
> > PostgreSQL, contrib, and documentation successfully made. Ready to install.
>
> > That seems kind of inconsistent and silly. I suggest we remove the
> > output from these scripts.
>
> FWIW, that'd be fine with me. Teodor spoke against removing that output
> entirely, but perhaps he's the only one who thinks that way. For myself,
> I've gotten mighty used to running "make -s" and expecting no output
> if all is well. If I wanted to see what was getting rebuilt, I wouldn't
> use -s.

+1 for making them not output anything if all is well.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2018-04-28 17:31:18 Re: [HACKERS] GSoC 2017: weekly progress reports (week 6)
Previous Message Tom Lane 2018-04-28 16:44:46 Re: inconsistency and inefficiency in setup_conversion()