| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section |
| Date: | 2018-04-27 23:16:42 |
| Message-ID: | 20180427231642.GA2124@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 28, 2018 at 12:36:16AM +0300, Stas Kelvich wrote:
> It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't
> hold interrupts around writing to wal and cleaning up ProcArray and GXact
> entries. At least RemoveTwoPhaseFile (which is called in between) can print
> a warning with ereport(), which, in turn will check for interrupts and
> therefore can cancel backend or throw an error before GXact clean-up.
>
> Other similar places like CommitTransaction and PrepareTransaction have
> such hold interrupts sections.
Good catch! The places you are suggesting look good to me as well.
That's something which should be back-patched as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2018-04-27 23:38:30 | Re: Postgres, fsync, and OSs (specifically linux) |
| Previous Message | Andres Freund | 2018-04-27 23:10:43 | Re: Postgres, fsync, and OSs (specifically linux) |