Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type

From: Andres Freund <andres(at)anarazel(dot)de>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: jitflags in _outPlannedStmt and _readPlannedStmt treated as bool type
Date: 2018-04-27 01:01:56
Message-ID: 20180427010156.p24vofp7gszxy3ie@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-04-26 13:34:44 +1000, Haribabu Kommi wrote:
> The jitflags in the PlannedStmt structure of type "int", but in _out and
> _read functions it is treated as of "bool" type.
>
> WRITE_BOOL_FIELD(jitFlags);
> READ_BOOL_FIELD(jitFlags);
>
> I am thinking of it is a copy paste mistake as the other members around the
> initflags are of "bool" type or is there any specific reason to treat as
> "bool" type?

No, it's an oversight. It was a bool first and then morphed from
there... Will fix.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2018-04-27 01:03:21 Re: Toast issues with OldestXmin going backwards
Previous Message Kyotaro HORIGUCHI 2018-04-27 01:01:11 Re: Oddity in tuple routing for foreign partitions