Re: Patch missing from back branches

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Haroon <muhammad(dot)haroon(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Patch missing from back branches
Date: 2018-04-26 05:29:50
Message-ID: 20180426052950.GB783@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 26, 2018 at 09:06:09AM +0500, Haroon wrote:
> Apparently the following patch[1] got committed to head only (9.6 at the
> time) and never made it into back branches i.e. 9.5, 9.4 and 9.3. Is it an
> oversight ?
>
> [1]
> http://git.postgresql.org/pg/commitdiff/868628e4fd44d75987d6c099ac63613cc5417629

The support of VS 2015 being back-patched down to 9.5 is intentional,
as the ideawhen integrating a new integration with visual studio is to
patch HEAD plus the latest major version already released, at least
that's the move respected for the last couple of years.

Now I think that you are right: we should have this patch present as
well in REL9_5_STABLE in order to be able to get the combination
REL9_5_STABLE/VS2015 working correctly. At least we have made efforts
to claim support of VS2015 down to 9.5, so I would suggest to
cherry-pick it and make the solution complete.

The discussion about _timezone and _tzdata is here by the way:
https://www.postgresql.org/message-id/CAB7nPqTEkqF7E7nWcdQSvyOUAV3OGjX%3DrKSxFTkk03TOJGF5ng%40mail.gmail.com

There is dory in the buildfarm which compiles using VS 2015, but it runs
only 9.6 and newer versions.

Robert? Or Magnus perhaps?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-04-26 06:10:46 Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager
Previous Message Haroon 2018-04-26 04:06:09 Patch missing from back branches