| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Gotchas about pg_verify_checksums |
| Date: | 2018-04-18 00:09:47 |
| Message-ID: | 20180418000947.GA18178@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 17, 2018 at 09:43:47PM +0200, Michael Banck wrote:
> So I decided to add some support for earlier version in my version of
> the program, and pushed it to https://github.com/credativ/pg_checksums
> if anybody is interested in that. I have to admit that it is quite less
> fancy than your version.
Both things have the same features, except that I added as well long
options. I can see two minor issues with your version:
1) The tool should not be allowed to run as root when using the enable
and disable modes.
2) On 11 and newer versions, you should use GetDataDirectoryCreatePerm()
to get the correct folder permissions and then set umask(pg_mode_mask).
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-04-18 00:14:41 | Re: Typos from Covering Index patch |
| Previous Message | David Rowley | 2018-04-18 00:07:18 | Should we add GUCs to allow partition pruning to be disabled? |