| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, seltenreich(at)gmx(dot)de |
| Subject: | Re: Guidelines on dropping objects in regression tests, sqlsmith |
| Date: | 2018-04-15 02:13:46 |
| Message-ID: | 20180415021346.guxtz7wml23wabkd@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Geoghegan wrote:
> Commit 975ad4e6 fixed a nasty bug in BRIN that was
> originally found by Andreas' fuzz testing. Perhaps that bug would
> still be around if Alvaro had included any DROP statements within
> brin.sql. Presumably his choice to not to do so was completely
> arbitrary. Actually, it seems likely that it was a fortunate accident.
As I recall, it was deliberate, as I tend to do that; I did it in
indexing.sql as well, and I think in foreign_key.sql too.
These objects are also dumped/restored by pg_dump in the pg_upgrade
test.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-04-15 02:52:55 | Re: Guidelines on dropping objects in regression tests, sqlsmith |
| Previous Message | Tom Lane | 2018-04-15 01:18:47 | Re: Guidelines on dropping objects in regression tests, sqlsmith |