| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Validate page level checksums in base backups |
| Date: | 2018-04-11 00:10:58 |
| Message-ID: | 20180411001058.GJ26769@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Apr 10, 2018 at 11:35:21PM +0200, Tomas Vondra wrote:
> BTW pg_verify_checksums needs the same fix.
Yes you are right here. Just for the record: what needs to be done is
to check for PageIsNew() in scan_file() before fetching
pg_checksum_page() and after reading an individual block, which applies
even to what HEAD has for pg_verify_checksums.c.
I am adding an open item for this one.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-04-11 06:58:14 | Re: pgsql: Support partition pruning at execution time |
| Previous Message | Peter Geoghegan | 2018-04-10 22:39:46 | Re: pgsql: Optimize btree insertions for common case of increasing values |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-04-11 00:17:14 | Re: [HACKERS] PATCH: Keep one postmaster monitoring pipe per process |
| Previous Message | Andres Freund | 2018-04-11 00:03:27 | Re: [HACKERS] PATCH: Keep one postmaster monitoring pipe per process |