| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Configurable file mode mask |
| Date: | 2018-04-07 22:29:53 |
| Message-ID: | 20180407222953.GB27724@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> >> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=culicidae&dt=2018-04-07%2021%3A50%3A02
>
> > Yes, I'm taking a look at it.
>
> Since other animals are coming back successfully, my first suspicion
> lights on culicidae's use of EXEC_BACKEND. Did you test that case?
> (If not, this bodes ill for the Windows results.)
The vast majority of this patch isn't something that's relevant to
Windows anyway, so I'm hopeful that those animals will stay green (if
not, it's probably that we need to mark some other test as
not-on-Windows).
We have EXEC_BACKEND on the Unix-y systems too though, so that needs to
be fixed. I'm pretty sure the issue here is that SubPostmasterMain()
needs to also be checking/updating the umask() based on the data
directory, as is done in PostmasterMain.
Testing that out now and if that looks good then I'll push that and
hopefully it'll make cullcidae green.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-04-07 22:42:07 | Re: PATCH: Configurable file mode mask |
| Previous Message | Andres Freund | 2018-04-07 22:24:45 | Searching for: Fast windows buildfarm animal |