From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | amul sul <sulamul(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key |
Date: | 2018-04-07 03:38:46 |
Message-ID: | 20180407033846.pl5q7y6q2ei7imy5@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Tom, All,
On 2018-04-06 14:19:02 +0530, amul sul wrote:
> Thanks for the reminder -- fixed in the attached version.
Tom, this seems to be the best approach for fixing the visibility issues
around this. I've spent a good chunk of time looking at corruption
issues like the ones you feared (see [1]) and I'm not particularly
concerned. I'm currently planning to go ahead with this, do you want to
"veto" that (informally, not formally)?
I'll go through this again tomorrow morning.
[1] https://postgr.es/m/20180405014439.fbezvbjrmcw64vjc@alap3.anarazel.de
> v9:
> Its the rebase version of Andres Freund patch v8[1] with the
> following additional changes:
> 3. Argument changing_part of heap_delete renamed to ChangingPart to be
> consistent with ExecDelete
FWIW, I'd left it as it was before because the two functions have a bit
different coding style, and the capitalization seemed more fitting in
the surrounding context.
> +test: partition-key-update-1
> +test: partition-key-update-2
> +test: partition-key-update-3
Can you give these more descriptive names please (or further combine them)?
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2018-04-07 03:39:23 | Re: [HACKERS] path toward faster partition pruning |
Previous Message | David Rowley | 2018-04-07 03:25:27 | Re: [HACKERS] path toward faster partition pruning |