| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: New files for MERGE |
| Date: | 2018-04-06 02:54:36 |
| Message-ID: | 20180406025436.GE4031@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Apr 05, 2018 at 04:02:20PM -0400, Bruce Momjian wrote:
> Simon, you have three committers in this thread suggesting this patch be
> reverted. Are you just going to barrel ahead with the fixes without
> addressing their emails?
If my opinion counts, please count me in this bucket as well. I have
seen also Peter G. commenting about the design of the patch in a very
advanced way and emit doubts, this is enough to convince me that
something wrong is going on here. I have to admit that I did not look
at the patch in details but the design issues for the executor and
parser mentioned show that some low-level considerations have not been
taken into account, so this is worrying.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2018-04-06 08:21:54 | Re: pgsql: New files for MERGE |
| Previous Message | Andrew Dunstan | 2018-04-06 00:03:31 | Re: pgsql: Allow on-line enabling and disabling of data checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Edmund Horner | 2018-04-06 03:01:43 | Re: PATCH: psql tab completion for SELECT |
| Previous Message | Thomas Munro | 2018-04-06 02:53:56 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |