| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | jesper(dot)pedersen(at)redhat(dot)com, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] path toward faster partition pruning |
| Date: | 2018-04-05 23:33:55 |
| Message-ID: | 20180405233355.wsukhhcfnvkoqv45@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> @@ -1717,8 +1691,8 @@ expand_partitioned_rtentry(PlannerInfo *root, RangeTblEntry *parentrte,
> * parentrte already has the root partrel's updatedCols translated to match
> * the attribute ordering of parentrel.
> */
> - if (!*part_cols_updated)
> - *part_cols_updated =
> + if (!root->partColsUpdated)
> + root->partColsUpdated =
> has_partition_attrs(parentrel, parentrte->updatedCols, NULL);
Hmm, surely this should be |= to avoid resetting a value set in a
previous call to this function? In the previous coding it wasn't
necessary because it was a local variable ... (though, isn't it a bit
odd to have this in PlannerInfo? seems like it should be in
resultRelInfo, but then you already have it there so I suppose this one
does *more*)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-04-05 23:34:30 | Re: Checkpoint not retrying failed fsync? |
| Previous Message | Thomas Munro | 2018-04-05 23:17:48 | Re: Checkpoint not retrying failed fsync? |