Re: pgsql: Validate page level checksums in base backups

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Validate page level checksums in base backups
Date: 2018-04-05 13:17:48
Message-ID: 20180405131748.3zrjzedxmhkr445v@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Banck wrote:
> Hi,

> > Do we have a precedent somewhere for how we do this, or does our test
> > framework already have a way to do it? How are all the actual data
> > directories etc cleaned up?
>
> They (and the base backups) are getting purged on success of the whole
> testsuite. So to be clear - we are not leaving behind 1 GB of disk space
> on success, but we use 1 GB of disk space during the test.

Yeah, but it means you force the OS to keep 1 GB of useless dung in
cache. I would hope that creating 40 MB, deleting those, then creating
further 40 MB (lather, rinse, repeat) would not overall evict 1 GB from
my OS cache. Unless the OS keeps the unlinked files in cache, which
would be stupid.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Pavan Deolasee 2018-04-05 13:27:40 Re: pgsql: Optimize btree insertions for common case of increasing values
Previous Message Michael Banck 2018-04-05 12:41:13 Re: pgsql: Validate page level checksums in base backups

Browse pgsql-hackers by date

  From Date Subject
Next Message Ernst-Georg Schmid 2018-04-05 13:20:52 AW: Get the name of the target Relation from Query struct?
Previous Message David Rowley 2018-04-05 12:59:14 Re: Get the name of the target Relation from Query struct?