Re: [HACKERS] GUC for cleanup indexes threshold.

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, sawada(dot)mshk(at)gmail(dot)com
Cc: a(dot)korotkov(at)postgrespro(dot)ru, simon(at)2ndquadrant(dot)com, y(dot)sokolov(at)postgrespro(dot)ru, pg(at)bowt(dot)ie, andres(at)anarazel(dot)de, robertmhaas(at)gmail(dot)com, david(at)pgmasters(dot)net, amit(dot)kapila16(at)gmail(dot)com, ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, pgsql-hackers(at)postgresql(dot)org, kuntalghosh(dot)2007(at)gmail(dot)com, pgsql-hackers-owner(at)postgresql(dot)org
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.
Date: 2018-04-05 10:23:17
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Thanks to everyone, fixes are pushed except nodeMerge.c, I don't wish to
increase entropy around MERGE patch :)

Kyotaro HORIGUCHI wrote:
> Hello.
> The commit leaves three warnings for
> -Wunused-but-set-variable. Two of them are not assertion-only but
> really not used at all.
> I also found that nodeMerge.c has one such variable.
> regards.
> At Thu, 5 Apr 2018 15:43:55 +0900, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote in <CAD21AoAtYzXeuhPqGw89KxqcJWpSKxWRNkYzyJxAqJHZham==Q(at)mail(dot)gmail(dot)com>
>> On Thu, Apr 5, 2018 at 2:40 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>> On Thu, Apr 5, 2018 at 1:30 AM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>>>> Thanks for everyone, pushed with minor editorization
>>> Thank you for committing!
>>> I found a typo in nbtpage.c and attached a patch fixes it.
>> I also found an incorrect documentation in create_index.sgml as follows.
>> <term><literal>vacuum_cleanup_index_scale_factor</literal></term>
>> <listitem>
>> <para>
>> Per-table value for <xref
>> linkend="guc-vacuum-cleanup-index-scale-factor"/>.
>> </para>
>> </listitem>
>> </varlistentry>
>> I think it should be "Per-index". Attached a patch for fixing it. And
>> sorry for missing it at review.
>> Regards,

Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2018-04-05 10:31:34 Re: Add support for printing/reading MergeAction nodes
Previous Message Etsuro Fujita 2018-04-05 10:21:05 Re: [HACKERS] Add support for tuple routing to foreign partitions