Re: Rewrite of pg_dump TAP tests

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Rewrite of pg_dump TAP tests
Date: 2018-04-04 14:25:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> * Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> > On Tue, Mar 06, 2018 at 11:53:41AM -0500, Stephen Frost wrote:
> > > * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > >> Attached is a patch (which applies cleaning against a2a2205, but not so
> > >> much anymore, obviously, but I will fix after the releases) which
> > >> greatly improves the big pg_dump TAP tests. There's probably more which
> > >> can be done, but I expect people will be much happier with this. The
> > >> cliff-notes are:
> > >
> > > Attached is an updated patch which applies cleanly against current
> > > master. I've not yet looked into back-patching these changes, but will
> > > if this can get some review and feedback, and folks like this better and
> > > are ok with the same being done in the back-branches.
> >
> > It would be nice to improve the readability of test_pg_dump's
> > at the same time by using similarly a hash syntax for common
> > options.
> Yes, good point, will fix.

I've updated those tests as well and rebased the patch (though no real
changes were needed for the rebase). Passes all tests. I'll take
another look through the changes again but plan to push them in a few
hours, later on this afternoon.



Attachment Content-Type Size
pg_dump_test_rewrite-v2_master.patch text/x-diff 248.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2018-04-04 14:25:47 Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS
Previous Message Craig Ringer 2018-04-04 14:09:09 Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS