Re: Rewrite of pg_dump TAP tests

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Rewrite of pg_dump TAP tests
Date: 2018-03-07 12:12:49
Message-ID: 20180307121249.GC2416@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael,

* Michael Paquier (michael(at)paquier(dot)xyz) wrote:
> On Tue, Mar 06, 2018 at 11:53:41AM -0500, Stephen Frost wrote:
> > * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> >> Attached is a patch (which applies cleaning against a2a2205, but not so
> >> much anymore, obviously, but I will fix after the releases) which
> >> greatly improves the big pg_dump TAP tests. There's probably more which
> >> can be done, but I expect people will be much happier with this. The
> >> cliff-notes are:
> >
> > Attached is an updated patch which applies cleanly against current
> > master. I've not yet looked into back-patching these changes, but will
> > if this can get some review and feedback, and folks like this better and
> > are ok with the same being done in the back-branches.
>
> It would be nice to improve the readability of test_pg_dump's
> 001_base.pl at the same time by using similarly a hash syntax for common
> options.

Yes, good point, will fix.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2018-03-07 12:14:43 Re: public schema default ACL
Previous Message Pavel Stehule 2018-03-07 12:02:07 Re: [PROPOSAL] Shared Ispell dictionaries