| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Validate page level checksums in base backups |
| Date: | 2018-04-03 17:13:56 |
| Message-ID: | 20180403171356.v4ji5sfhbc4sggij@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-04-03 11:52:26 +0000, Magnus Hagander wrote:
> Validate page level checksums in base backups
>
> When base backups are run over the replication protocol (for example
> using pg_basebackup), verify the checksums of all data blocks if
> checksums are enabled. If checksum failures are encountered, log them
> as warnings but don't abort the backup.
>
> This becomes the default behaviour in pg_basebackup (provided checksums
> are enabled on the server), so add a switch (-k) to disable the checks
> if necessary.
>
> Author: Michael Banck
> Reviewed-By: Magnus Hagander, David Steele
> Discussion: https://postgr.es/m/20180228180856.GE13784@nighthawk.caipicrew.dd-dns.de
Hm, something isn't quite right with the test:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pogona&dt=2018-04-03%2016%3A10%3A01
# WARNING: 6 total checksum verification failures
# pg_basebackup: checksum error occured
# '
# doesn't match '(?^s:^WARNING.*7 total checksum verification failures)'
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2018-04-03 17:17:16 | Re: pgsql: Validate page level checksums in base backups |
| Previous Message | Teodor Sigaev | 2018-04-03 16:47:48 | pgsql: Add prefix operator for TEXT type. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2018-04-03 17:17:16 | Re: pgsql: Validate page level checksums in base backups |
| Previous Message | Anthony Iliopoulos | 2018-04-03 16:52:07 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |