From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: pgsql: Add documentation for the JIT feature. |
Date: | 2018-03-31 16:27:44 |
Message-ID: | 20180331162744.ov2ucfqwwxhdr5vm@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On March 31, 2018 8:43:37 AM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I don't want to waste cycles on testing docs when I'm trying
> >> to test code, any more than I would like the reverse (ie forcing a docs
> >> build to build code too).
>
> > They're a local check target in the docs directory. But it just checks
> > postgres.xml, not additional targets. Don't think anybody proposed to
> > add the doc check to the top-level check target.
>
> Ah, didn't realize that "make check" in the docs isn't connected up to
> the main check target. As long as that's true, no objection.
I'm not proposing to add doc/src/sgml's check target to top-level check,
though perhaps it wouldn't be such a terrible idea -- seems quick
enough, at under half a second:
$ time LC_ALL=C make -C doc/src/sgml/ check
make: Entering directory '/home/alvherre/Code/pgsql/build/master/doc/src/sgml'
/usr/bin/xmllint --path . --noout --valid /pgsql/source/master/doc/src/sgml/postgres.sgml
make: Leaving directory '/home/alvherre/Code/pgsql/build/master/doc/src/sgml'
real 0m0,494s
user 0m0,461s
sys 0m0,033s
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-03-31 16:32:42 | pgsql: Fix portability and translatability issues in commit 64f85894a. |
Previous Message | Tom Lane | 2018-03-31 15:58:34 | Re: pgsql: Add documentation for the JIT feature. |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-03-31 16:38:12 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
Previous Message | Craig Ringer | 2018-03-31 16:13:09 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |