Re: Small proposal to improve out-of-memory messages

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Small proposal to improve out-of-memory messages
Date: 2018-03-31 13:36:07
Message-ID: 20180331133607.gbtc2wot3rnsewar@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> In the wake of commit 442accc3f one might think that the message should
> also include the context "identifier" if any. But I'm specifically not
> proposing that, because of the point made in the discussion of that patch
> that some identifier strings might contain security-sensitive query
> excerpts. Now that that commit has required all context "names" to be
> compile-time constants, it's hard to see how there could be any security
> downside to showing them in a user-visible message.

How about using errdetail_log() to include the context identifier?

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-03-31 13:52:09 Re: [HACKERS] Runtime Partition Pruning
Previous Message John Naylor 2018-03-31 13:32:33 Re: WIP: a way forward on bootstrap data