Re: [HACKERS] logical decoding of two-phase transactions

From: Andres Freund <andres(at)anarazel(dot)de>
To: Nikhil Sontakke <nikhil(dot)sontakke(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Sokolov Yura <y(dot)sokolov(at)postgrespro(dot)ru>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2018-03-30 18:50:37
Message-ID: 20180330185037.ehgvu4lplcgwekqr@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-03-30 23:49:43 +0530, Nikhil Sontakke wrote:
> > Quick thought: Should be simple to release lock when interacting with network.
>
> I don’t think this will be that simple. The network calls will
> typically happen from inside the plugins and we don’t want to make
> plugin authors responsible for that.

You can just throw results away... ;). I'm not even kidding. We've all
the necessary access in the callback for writing from a context.

> > Could also have abort signal lockers.
>
> With the decodegroup locking we do have access to all the decoding backend pids. So we could signal them. But am not sure signaling will work if the plugin is in the midst of a network
> Call.

All walsender writes are nonblocking, so that's not an issue.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Lukas Fittl 2018-03-30 19:04:41 Re: [HACKERS] Planning counters in pg_stat_statements
Previous Message Petr Jelinek 2018-03-30 18:43:01 Re: [HACKERS] logical decoding of two-phase transactions