Re: Protect syscache from bloating with negative cache entries

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: andres(at)anarazel(dot)de
Cc: david(at)pgmasters(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, robertmhaas(at)gmail(dot)com, michael(dot)paquier(at)gmail(dot)com, Jim(dot)Nasby(at)bluetreble(dot)com, craig(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Protect syscache from bloating with negative cache entries
Date: 2018-03-30 01:35:48
Message-ID: 20180330.103548.147628376.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 29 Mar 2018 18:22:59 -0700, Andres Freund <andres(at)anarazel(dot)de> wrote in <20180330012259(dot)7k3442yz7jighg2t(at)alap3(dot)anarazel(dot)de>
> On 2018-03-23 17:01:11 +0900, Kyotaro HORIGUCHI wrote:
> > Hello.
> >
> > At Wed, 21 Mar 2018 15:28:07 -0400, David Steele <david(at)pgmasters(dot)net> wrote in <43095b16-14fc-e4d8-3310-2b86eaaab662(at)pgmasters(dot)net>
> > > On 3/15/18 1:12 AM, Kyotaro HORIGUCHI wrote:
> > > > At Mon, 12 Mar 2018 17:34:08 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in >
> > > > The attached is the patch set including this plancache stuff.
> > > >
> > > > 0001- catcache time-based expiration (The origin of this thread)
> > > > 0002- introduces dynahash pruning feature
> > > > 0003- implement relcache pruning using 0002
> > > > 0004- (perhaps) independent from the three above. PoC of
> > > > plancache pruning. Details are shown above.
> > >
> > > It looks like this should be marked Needs Review so I have done so. If
> > > that's not right please change it back or let me know and I will.
> >
> > Mmm. I haven't noticed that. Thanks!
>
> I actually think this should be marked as returned with feedback, or at
> the very least moved to the next CF. This is entirely new development
> within the last CF. There's no realistic way we can get this into v11.

0002-0004 is new, in response to the comment that caches other
than the catcache ought to get the same feature. These can be a
separate development from 0001 for v12. I don't find a measures
to catch the all case at once.

If we agree on the point. I wish to discuss only 0001 for v11.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-03-30 01:51:45 Re: Protect syscache from bloating with negative cache entries
Previous Message Bruce Momjian 2018-03-30 01:25:46 Re: Fix missing spaces in docs