Re: [HACKERS] [PATCH] Lockable views

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: robertmhaas(at)gmail(dot)com, thomas(dot)munro(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] [PATCH] Lockable views
Date: 2018-03-28 11:26:48
Message-ID: 20180328202648.0a816239.nagata@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, 28 Mar 2018 15:45:09 +0900 (JST)
Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:

> >> I found the previous patch was broken and this can't handle
> >> views that has subqueries as bellow;
> >>
> >>  CREATE VIEW lock_view6 AS SELECT * from (select * from lock_tbl1) sub;
> >>
> >> I fixed this and attached the updated version including additional tests.
> >
> > This patch gives a warning while compiling:
> >
> > lockcmds.c:186:1: warning: no semicolon at end of struct or union
> > } LockViewRecurse_context;
> > ^
>
> Also I get a regression test failure:

Thank you for your reviewing my patch.
I attached the updated patch, v10.

Regards,

>
> *** /usr/local/src/pgsql/current/postgresql/src/test/regress/expected/lock.out 2018-03-28 15:24:13.805314577 +0900
> --- /usr/local/src/pgsql/current/postgresql/src/test/regress/results/lock.out 2018-03-28 15:42:07.975592594 +0900
> ***************
> *** 118,124 ****
> ------------
> lock_tbl1
> lock_view6
> ! (2 rows)
>
> ROLLBACK;
> -- Verify that we can lock a table with inheritance children.
> --- 118,125 ----
> ------------
> lock_tbl1
> lock_view6
> ! mvtest_tm
> ! (3 rows)
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

Attachment Content-Type Size
lock_view-v10.patch text/x-diff 14.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2018-03-28 12:04:09 Re: [HACKERS] A design for amcheck heapam verification
Previous Message Pavan Deolasee 2018-03-28 11:00:42 Re: [HACKERS] MERGE SQL Statement for PG11