From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
---|---|
To: | nagata(at)sraoss(dot)co(dot)jp |
Cc: | ishii(at)sraoss(dot)co(dot)jp, robertmhaas(at)gmail(dot)com, thomas(dot)munro(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] [PATCH] Lockable views |
Date: | 2018-03-28 13:12:57 |
Message-ID: | 20180328.221257.926934461399157915.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Wed, 28 Mar 2018 15:45:09 +0900 (JST)
> Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>
>> >> I found the previous patch was broken and this can't handle
>> >> views that has subqueries as bellow;
>> >>
>> >> CREATE VIEW lock_view6 AS SELECT * from (select * from lock_tbl1) sub;
>> >>
>> >> I fixed this and attached the updated version including additional tests.
>> >
>> > This patch gives a warning while compiling:
>> >
>> > lockcmds.c:186:1: warning: no semicolon at end of struct or union
>> > } LockViewRecurse_context;
>> > ^
>>
>> Also I get a regression test failure:
>
> Thank you for your reviewing my patch.
> I attached the updated patch, v10.
Thanks. Looks good to me. I marked the patch as "Ready for Committer".
Unless there's an objection, especially from Robert or Thomas Munro, I
am going to commit/push it.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
From | Date | Subject | |
---|---|---|---|
Next Message | Teodor Sigaev | 2018-03-28 13:15:41 | Re: [HACKERS] [PATCH] Incremental sort |
Previous Message | Tomas Vondra | 2018-03-28 13:00:24 | Re: PL/pgSQL nested CALL with transactions |