| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3) |
| Date: | 2018-03-17 18:04:36 |
| Message-ID: | 20180317180436.q2ff7i33gsibqkka@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-03-17 18:55:11 +0100, Tomas Vondra wrote:
> Not sure, but the backbranches seem to be working fine, and the commit
> that triggers the issue is from December 31.
Well, that added the test. Are you saying that if you execute similar
code on an older branch it doesn't fail?
> Anyway, I can confirm that the fix suggested by Tom does the trick
Could you try the attached patch, too?
I'm a bit afraid that we'll have to go a lot further if we can't make
icc do safe signed overflow in all cases. This case is easy enough to
fix, but we were lucky in a way to find it. Given that apparently we
know that ICC also optimizes based on overflow sematics it seems we
should really work towards making all of the backend safe with that :(.
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| overflow.patch | text/x-diff | 889 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-17 18:20:26 | Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3) |
| Previous Message | Tomas Vondra | 2018-03-17 17:55:11 | Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3) |