| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ExplainProperty* and units |
| Date: | 2018-03-16 21:25:12 |
| Message-ID: | 20180316212512.6kudvfryyk5a3ugq@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-03-14 13:32:10 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Only thing I wonder is if we shouldn't just *remove*
> > ExplainPropertyLong and make ExplainPropertyInteger accept 64bits of
> > input - the effort of passing and printing a 64bit integer will never be
> > relevant for explain.
>
> -0.5 ... everywhere else, we mean "int32" when we say "int", and I don't
> think it's worth the potential confusion to do it differently here.
Since I'm +1 on this (I don't think Integer is the same as int, there's
no benefit in having two functions, and I've already written the patch
this way), I'm inclined to go with one function. Does anybody else
have an opinion?
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-16 21:28:51 | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Previous Message | Alvaro Herrera | 2018-03-16 21:23:44 | Re: ON CONFLICT DO UPDATE for partitioned tables |