| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Comment fixes in create_grouping_paths() add_paths_to_append_rel() |
| Date: | 2018-03-14 16:41:17 |
| Message-ID: | 20180314164117.GM2416@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings Ashutosh,
* Ashutosh Bapat (ashutosh(dot)bapat(at)enterprisedb(dot)com) wrote:
> Here are two patches fixing comments.
Thanks!
> 0001
> A comment in add_paths_to_append_rel() mentions the number of paths
> instead of number of workers by mistake. Fixed it.
This looks alright.
> 0002
> Commit b5635948ab165b6070e7d05d111f966e07570d81 added a single
> grouping_sets_data argument instead of two lists related to grouping
> sets to create_grouping_paths(), but forgot to update the prologue of
> the function. Fixed it.
This also looks good, but misses a similar mishap from that commit, in
the function header of get_number_of_groups().
Patch attached.
Will push soon.
Thanks!
Stephen
| Attachment | Content-Type | Size |
|---|---|---|
| fix-func-header-comments-grouping-sets-v1-master.patch | text/x-diff | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-03-14 16:48:32 | Re: ExplainProperty* and units |
| Previous Message | Andres Freund | 2018-03-14 16:07:09 | Re: ExplainProperty* and units |