Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pavel(dot)stehule(at)gmail(dot)com, a(dot)zakirov(at)postgrespro(dot)ru, michael(dot)paquier(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Date: 2018-03-14 08:46:21
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Mar 14, 2018 at 05:30:59PM +0900, Kyotaro HORIGUCHI wrote:
> Doesn't it make sense if we provide a buildtime-script that
> collects the function names and builds a .h file containing a
> function using the list?
> The attached perl script is a rush work of such script, which
> works at the top of the source tree. It just prints the function
> definition, does not generate a .h file.
> I haven't confirmed anything about it but I had the following
> output from the current master.

I quite like that idea actually. Please note that pl_handler.c declares
two more of them, so we may want a smarter parsing which takes into
account declarations of DefineCustom*Variable.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2018-03-14 09:02:51 Re: Fixes for missing schema qualifications
Previous Message Etsuro Fujita 2018-03-14 08:45:18 Incorrect comment for ExecProcessReturning