Re: PATCH: Configurable file mode mask

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Steele <david(at)pgmasters(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Configurable file mode mask
Date: 2018-03-14 01:27:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Mar 13, 2018 at 01:28:17PM -0400, Tom Lane wrote:
> David Steele <david(at)pgmasters(dot)net> writes:
>> On 3/12/18 3:28 AM, Michael Paquier wrote:
>>> In pg_rewind and pg_resetwal, isn't that also a portion which is not
>>> necessary without the group access feature?
>> These seem like a good idea to me with or without patch 03. Some of our
>> front-end tools (initdb, pg_upgrade) were setting umask and others
>> weren't. I think it's more consistent (and safer) if they all do, at
>> least if they are writing into PGDATA.
> +1 ... see a926eb84e for an example of how easy it is to screw up if
> the process's overall umask is permissive.

Okay. A suggestion that I have here would be to split those extra calls
into a separate patch. That's a useful self-contained improvement.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-03-14 01:31:42 Re: PATCH: Configurable file mode mask
Previous Message David Gould 2018-03-14 01:10:14 Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate.