Re: Prefix operator for text and spgist support

From: Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>
To: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Prefix operator for text and spgist support
Date: 2018-03-12 11:36:11
Message-ID: 20180312143611.67be88bc@wp.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, 6 Mar 2018 19:27:21 +0300
Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:

> On Mon, Feb 19, 2018 at 05:19:15PM +0300, Ildus Kurbangaliev wrote:
> > At brief look at this place seems better to move this block into
> > pattern_fixed_prefix function. But there is also `vartype` variable
> > which used to in prefix construction, and it would require pass this
> > variable too. And since pattern_fixed_prefix called in 10 other
> > places and vartype is required only for this ptype it seems better
> > just keep this block outside of this function.
> Understood.
> > I've added documentation in current version of the patch.
> Thank you.
> Can you rebase the patch due to changes within pg_proc.h?
> Also here
> + <para>
> + There is also the prefix operator <literal>^@</literal> and
> corresponding
> + <literal>text_startswith</literal> function which covers cases
> when only
> + searching by beginning of the string is needed.
> + </para>
> I think text_startswith should be enclosed with the <function> tag.
> I'm not sure, but I think <literal> used for operators, keywords,
> etc. I haven't found a manual which describes how to use tags, but
> after looking at the documentation where <function> is used, I think
> that for function <function> should be used.

Hi, thanks for the review. I've fixed documentation as you said and
also rebased to current master.

Ildus Kurbangaliev
Postgres Professional:
Russian Postgres Company

Attachment Content-Type Size
prefix_operator_and_spgist_v3.patch text/x-patch 15.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Badrul Chowdhury 2018-03-12 11:55:45 RE: Intermittent pg_ctl failures on Windows
Previous Message Anastasia Lubennikova 2018-03-12 11:26:27 Re: pg_serial early wraparound