Re: Failed to request an autovacuum work-item in silence

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Failed to request an autovacuum work-item in silence
Date: 2018-03-08 13:46:56
Message-ID: 20180308134656.4vp5uw3yaygadf5t@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

I was thinking that the BRIN code requesting the workitem would print
the error message based on the return value. There is no point to
returning a boolean indicator if the caller isn't going to do anything
with it ... This means you don't need to convert the type to string in
autovacuum.c (which would defeat attempts at generalizing this code).

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julian Markwort 2018-03-08 13:55:36 Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)
Previous Message David Rowley 2018-03-08 13:11:33 Re: ALTER TABLE ADD COLUMN fast default