Re: pgsql: Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)
Date: 2018-03-06 16:23:21
Message-ID: 20180306162321.stdnwdi6dmvhkcsk@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Thomas Munro wrote:
> > On Tue, Mar 6, 2018 at 11:39 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > > Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)
> >
> > Is this commit responsible for this valgrind error?
> >
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-03-05%2023%3A03%3A01

> Uh ... it probably is. I'll take a look tomorrow, but my guess is that
> my last minute removal of the conversion to Name is to blame.

I was right about the cause. Fix pushed. Thanks for notifying.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2018-03-06 19:42:53 pgsql: Raise Test::More version requirement
Previous Message Alvaro Herrera 2018-03-06 16:22:10 pgsql: Fix bogus Name assignment in CreateStatistics

Browse pgsql-hackers by date

  From Date Subject
Next Message Robbie Harwood 2018-03-06 16:25:13 Re: Kerberos test suite
Previous Message Alvaro Herrera 2018-03-06 16:22:41 Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)?