| From: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw |
| Date: | 2018-03-06 14:00:25 |
| Message-ID: | 20180306140024.GA12795@zakirov.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 06, 2018 at 08:09:50PM +0900, Etsuro Fujita wrote:
> Agreed. I added a comment to that function. I think that that comment in
> combination with changes to the FDW docs in the patch would help FDW authors
> understand why that is needed. Please find attached an updated version of
> the patch.
Thank you.
All tests pass, the documentation builds. There was the suggestion [1]
of different approach. But the patch fix the issue in much more simple
way.
Marked as "Ready for Commiter".
1 - https://www.postgresql.org/message-id/20171005.200631.134118679.horiguchi.kyotaro%40lab.ntt.co.jp
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2018-03-06 14:04:59 | Re: Re: [PATCH] Atomic pgrename on Windows |
| Previous Message | Ildar Musin | 2018-03-06 13:47:43 | Re: General purpose hashing func in pgbench |