Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids().

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids().
Date: 2018-03-06 00:58:04
Message-ID: 20180306005804.wdqt2jd2kh2qzjpq@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2018-03-05 19:53:23 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Scratch that, we should be going down the
> > /* If caller supplied OID, there's nothing we need do here. */
> > branch in expand_vacuum_rel() for autovacuum, so this shouldn't
> > matter. Sorry for the noise
>
> But you said you'd seen blocking behind AEL with NOWAIT, so there's
> still a problem for manual vacuums no?

Right. But that facility isn't yet exposed to SQL, just in the patch I'm
reviewing. So there's no issue with the code from the commit I'm
replying to.

In [1] I wrote about one idea how to resolve this for the proposed
patch.

Greetings,

Andres Freund

[1] https://www.postgresql.org/message-id/20180306005349.b65whmvj7z6hbe2y@alap3.anarazel.de

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-03-06 01:52:51 pgsql: Add parenthesized options syntax for ANALYZE.
Previous Message Michael Paquier 2018-03-06 00:57:54 Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids().

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-03-06 01:03:45 Re: PATCH: Configurable file mode mask
Previous Message Michael Paquier 2018-03-06 00:57:54 Re: [COMMITTERS] pgsql: Fix inadequate locking during get_rel_oids().