| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, Stephen Froehlich <s(dot)froehlich(at)cablelabs(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Date: | 2018-03-05 22:43:20 |
| Message-ID: | 20180305224320.plmhsyjjeqkk2vfj@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-novice |
Pushed now, to branches master and pg10, with Tomas changes. I made a
few changes of my own
1. you forgot to update various src/backend/nodes/ files
2. I got rid of "NameData stxname" variable in CreateStatistics, which
seems pointless now. We can work with a cstring only. Not sure why we
had that one ...
3. I chose not to backpatch the node->stxcomment thing. It makes me
nervous to modify a parse node. So cloning the comments is a PG11
thing. Hopefully it's not *too* bad ...
4. See elsewhere in the thread about list_copy vs. list_concat :-)
Thanks,
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-03-05 22:50:10 | Re: 2018-03 CFM |
| Previous Message | Alvaro Herrera | 2018-03-05 22:39:01 | pgsql: Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2018-03-06 07:21:24 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |
| Previous Message | Alvaro Herrera | 2018-03-05 22:08:15 | Re: STATISTICS retained in CREATE TABLE ... LIKE (INCLUDING ALL)? |