Re: [PoC PATCH] Parallel dump to /dev/null

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: Andreas 'ads' Scherbaum <adsmail(at)wars-nicht(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PoC PATCH] Parallel dump to /dev/null
Date: 2018-03-05 16:56:09
Message-ID: 20180305165609.kq5y7uzy64o45vsg@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

I made a few amendments (here's v5) and was ready to push, when I
noticed that _StartBlobs() does not seem to be doing the right thing.
Did you test this with a few large objects?

The reason I noticed is I wondered about the amount of open() calls
(plus zlib function calls) we would save by keeping an FD open to
/dev/null, rather than opening it over and over for each object -- ie.,
maybe not touch setFilePath() at all, if possible. That looks perhaps
too invasive, so maybe not. But do audit other callsites that may open
files.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
v5-0001-Allow-parallel-dump-to-go-to-dev-null.patch text/plain 4.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2018-03-05 16:57:09 Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw
Previous Message Aleksander Alekseev 2018-03-05 16:52:08 Re: 2018-03 CFM