Re: [PoC PATCH] Parallel dump to /dev/null

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Michael Banck <michael(dot)banck(at)credativ(dot)de>
Cc: Andreas 'ads' Scherbaum <adsmail(at)wars-nicht(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PoC PATCH] Parallel dump to /dev/null
Date: 2018-03-05 15:48:26
Message-ID: 20180305154826.7c5ie2c37qx2s2xv@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Please make ctx->discard a bool, not an int.

You can initialize it like this:
ctx->discard = strcmp(ctx->directory, DEVNULL) == 0;

Why do you change the mode to create directory to 0711 from 0700?

You have a cuddled "else" in the last hunk. Please uncuddle.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2018-03-05 15:48:38 Re: PATCH: psql tab completion for SELECT
Previous Message Robert Haas 2018-03-05 15:38:40 planner failure with ProjectSet + aggregation + parallel query