Re: Incorrect use of "an" and "a" in code comments and docs

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Incorrect use of "an" and "a" in code comments and docs
Date: 2018-03-05 05:51:18
Message-ID: 20180305055118.vkqfmfrrer7ukpsw@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At 2018-03-05 14:42:14 +0900, michael(at)paquier(dot)xyz wrote:
>
> > - sinval is a signal invalidation, so it seems to me that "a" is
> > correct, not "an".

I guess it depends on whether you read it as "sin-val" or "ess-inval".

> diff --git a/src/backend/access/gin/ginvacuum.c b/src/backend/access/gin/ginvacuum.c
> index 398532d80b..8b08b46ff6 100644
> --- a/src/backend/access/gin/ginvacuum.c
> +++ b/src/backend/access/gin/ginvacuum.c
> @@ -381,7 +381,7 @@ ginVacuumPostingTreeLeaves(GinVacuumState *gvs, BlockNumber blkno, bool isRoot)
>
> /*
> * All subtree is empty - just return true to indicate that parent
> - * must do a cleanup. Unless we are ROOT an there is way to go upper.
> + * must do a cleanup. Unless we are ROOT and there is way to go upper.
> */

That particular comment could use some more changes. :-)

-- Abhijit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-03-05 05:51:52 Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly
Previous Message Michael Paquier 2018-03-05 05:42:14 Re: Incorrect use of "an" and "a" in code comments and docs