| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Sigh, I broke crake again |
| Date: | 2018-02-27 18:42:19 |
| Message-ID: | 20180227184219.xbzdier34oqybuih@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-02-27 13:36:59 -0500, Tom Lane wrote:
> I just committed some regression test cleanup that removed or renamed
> a couple of C-language functions in regress.so. I see that crake is
> now failing XversionUpgrade tests, and although I can't see the details,
> I bet the problem is from trying to load CREATE FUNCTION commands from
> the old regression databases that now don't point to an existing C
> function.
>
> Does it seem practical to adjust TestUpgradeXversion.pm to cope with
> this change? An alternative answer is to put back C-language stubs
> in regress.c for the removed functions, but that seems a bit grotty.
Could we just drop the relevant functions in the course of the test?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-02-27 18:43:23 | Re: atomics.h may not be included from frontend code |
| Previous Message | Robert Haas | 2018-02-27 18:40:14 | Re: [HACKERS] Partition-wise aggregation/grouping |