| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: SHA-2 functions |
| Date: | 2018-02-22 06:05:39 |
| Message-ID: | 20180222060539.GA3370@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 21, 2018 at 03:45:17PM -0500, Peter Eisentraut wrote:
> On 2/20/18 23:04, Michael Paquier wrote:
>> I think that crypto_hash.c or hash_crypt.c would be adapted as well.
>> crypt.c is too much generic, so including both concepts in the name is
>> the way to go. The name given by Tom here sounds actually nice.
>
> Updated patches
I have been reviewing both patches, and those look good to me.
git diff --check has one complain:
src/backend/utils/adt/cryptohashes.c:170: new blank line at EOF.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2018-02-22 07:50:31 | Re: PATCH: pgbench - break out timing data for initialization phases |
| Previous Message | Tom Lane | 2018-02-22 05:35:13 | Re: pgsql: Charge cpu_tuple_cost * 0.5 for Append and MergeAppend nodes. |