Re: reorganizing partitioning code (was: Re: [HACKERS] path toward faster partition pruning)

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reorganizing partitioning code (was: Re: [HACKERS] path toward faster partition pruning)
Date: 2018-02-14 20:25:21
Message-ID: 20180214202521.tbt7ck565gqtfszx@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This is looking attractive.

Please don't #include postgres.h in partcache.h. That's per policy.

Why do you need to #include parsenodes.h in partcache.h?

I think rewriteManip.h can do with just relcache.h rather than rel.h
(probably partition.h can do likewise)

thanks

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-02-14 20:25:35 Re: tapeblocks is uninitialized in logtape.c
Previous Message rqtx 2018-02-14 19:45:30 [HACKERS] Inserting data into a new catalog table via source code