Re: Why does load_external_function() return PGFunction?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Why does load_external_function() return PGFunction?
Date: 2018-02-07 06:54:58
Message-ID: 20180207065458.sowsqipstl7kinhf@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018-02-06 15:43:29 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > We've several callers to load_external_function() that do not use the
> > returned value as a PGFunction. I'd vote for changing the return type to
> > void * and have fmgr.c cast it to PGFunction after verifying the
> > function's magic.
>
> void* isn't necessarily compatible with function pointers --- there are
> platforms where they're physically different widths, though possibly
> you'd never get PG to run on such hardware anyway.

Fair point. Although we're relying on dlsym like infrastructure, which
returns just a void *.

> However, given that a cast is going to be necessary anyway, it seems
> like this is mostly useless churn...

Ok, can live with that too. Just though it was a bit weird...

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2018-02-07 07:11:25 Re: Query running for very long time (server hanged) with parallel append
Previous Message Pavel Stehule 2018-02-07 06:34:44 Re: [HACKERS] proposal: schema variables